Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 2 Dec 2016 19:24:58 +0000 (UTC)
From: "huaxiang sun (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13025162.1480703861000.426441.1480706698442@Atlassian.JIRA>
In-Reply-To: <JIRA.13025162.1480703861000@Atlassian.JIRA>
References: <JIRA.13025162.1480703861000@Atlassian.JIRA> <JIRA.13025162.1480703861822@arcas>
Subject: [jira] [Updated] (HBASE-17243) Reuse CompactionPartitionId and
 avoid creating MobFileName in PartitionedMobCompactor to avoid unnecessary
 new objects
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 02 Dec 2016 19:25:00 -0000


     [ https://issues.apache.org/jira/browse/HBASE-17243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

huaxiang sun updated HBASE-17243:
---------------------------------
    Status: Patch Available  (was: Open)

> Reuse CompactionPartitionId and avoid creating MobFileName in PartitionedMobCompactor to avoid unnecessary new objects
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17243
>                 URL: https://issues.apache.org/jira/browse/HBASE-17243
>             Project: HBase
>          Issue Type: Improvement
>          Components: mob
>    Affects Versions: 2.0.0
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>            Priority: Minor
>         Attachments: HBASE-17243-master-001.patch
>
>
> In today's select() implementation, when it is an existing id, the new allocated object is discarded. It should be reused. fileName is created to getStartKey and getDate(), utility APIs can be created to directly get these fields from the string.
> {code}
>       } else if (allFiles || linkedFile.getLen() < mergeableSize) {
>         // add all files if allFiles is true,
>         // otherwise add the small files to the merge pool
>         MobFileName fileName = MobFileName.create(linkedFile.getPath().getName());
>         CompactionPartitionId id = new CompactionPartitionId(fileName.getStartKey(),
>           fileName.getDate());
>         CompactionPartition compactionPartition = filesToCompact.get(id);
>         if (compactionPartition == null) {
>           compactionPartition = new CompactionPartition(id);
>           compactionPartition.addFile(file);
>           filesToCompact.put(id, compactionPartition);
>         } else {
>           compactionPartition.addFile(file);
>         }
>         selectedFileCount++;
>       }
>     }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)