Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 5 Dec 2016 08:16:58 +0000 (UTC)
From: "Anoop Sam John (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13025108.1480691050000.436560.1480925818384@Atlassian.JIRA>
In-Reply-To: <JIRA.13025108.1480691050000@Atlassian.JIRA>
References: <JIRA.13025108.1480691050000@Atlassian.JIRA> <JIRA.13025108.1480691050031@arcas>
Subject: [jira] [Commented] (HBASE-17241) Avoid compacting already compacted
  mob files with _del files
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 05 Dec 2016 08:17:00 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15721564#comment-15721564 ] 

Anoop Sam John commented on HBASE-17241:
----------------------------------------

So some file paths are removed as per the new logic
Still we continue with below with out any check
PartitionedMobCompactionRequest request = new PartitionedMobCompactionRequest( filesToCompact.values(), allDelFiles);
When filesToCompact become empty, still to go ahead this way?


> Avoid compacting already compacted  mob files with _del files
> -------------------------------------------------------------
>
>                 Key: HBASE-17241
>                 URL: https://issues.apache.org/jira/browse/HBASE-17241
>             Project: HBase
>          Issue Type: Improvement
>          Components: mob
>    Affects Versions: 2.0.0
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17241-master-002.patch, HBASE-17241-master-003.patch, HBASE-17241.master.001.patch
>
>
> Today if there is only one file in the partition, and there is no _del files, the file is skipped. With del file, the current logic is to compact the already-compacted file with _del file. Let's say there is one mob file regionA20161101***, which was compacted. On 12/1/2016, there is _del file regionB20161201**_del, mob compaction kicks in, regionA20161101*** is less than the threshold, and it is picked for compaction. Since there is a _del file, regionA20161101**** and regionB20161201***_del are compacted into regionA20161101**_1 . After that, regionB20161201**_del cannot be deleted since it is not a allFile compaction. The next mob compaction, regionA20161101**_1 and regionB20161201**_del will be picked up again and be compacted into regionA20161101***_2. So in this case, it will cause more unnecessary IOs.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)