Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 2 Dec 2016 19:49:58 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13024996.1480664016000.426741.1480708198482@Atlassian.JIRA>
In-Reply-To: <JIRA.13024996.1480664016000@Atlassian.JIRA>
References: <JIRA.13024996.1480664016000@Atlassian.JIRA> <JIRA.13024996.1480664016753@arcas>
Subject: [jira] [Commented] (HBASE-17235) Improvement in creation of CIS for
 onheap buffer cases
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 02 Dec 2016 19:50:00 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716090#comment-15716090 ] 

stack commented on HBASE-17235:
-------------------------------

+1

> Improvement in creation of CIS for onheap buffer cases
> ------------------------------------------------------
>
>                 Key: HBASE-17235
>                 URL: https://issues.apache.org/jira/browse/HBASE-17235
>             Project: HBase
>          Issue Type: Improvement
>          Components: rpc
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17235.patch, HBASE-17235_1.patch
>
>
> {code}
>       if (buf.hasArray()) {
>         cis = CodedInputStream.newInstance(buf.array(), offset, buf.limit());
>       } else {
> {code}
> Currently we do this for onheap buffers incase there is no reservoir or the size is less than the minSizeforReservoir. I could see that even if reservoir is there there are requests which goes with the above way of creating CIS. This could be made efficient to avoid underlying copies by just doing this
> {code}
> cis = UnsafeByteOperations.unsafeWrap(buf.array(), offset, buf.limit()).newCodedInput();
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)