Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3C9DD200BDE for ; Thu, 1 Dec 2016 20:04:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 39A10160B0B; Thu, 1 Dec 2016 19:04:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8D798160B10 for ; Thu, 1 Dec 2016 20:03:59 +0100 (CET) Received: (qmail 59722 invoked by uid 500); 1 Dec 2016 19:03:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 59448 invoked by uid 99); 1 Dec 2016 19:03:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Dec 2016 19:03:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6A9B02C2A69 for ; Thu, 1 Dec 2016 19:03:58 +0000 (UTC) Date: Thu, 1 Dec 2016 19:03:58 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17206) FSHLog may roll a new writer successfully with unflushed entries MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 01 Dec 2016 19:04:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-17206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712767#comment-15712767 ] Hudson commented on HBASE-17206: -------------------------------- ABORTED: Integrated in Jenkins build HBase-1.1-JDK8 #1907 (See [https://builds.apache.org/job/HBase-1.1-JDK8/1907/]) HBASE-17206 FSHLog may roll a new writer successfully with unflushed (zhangduo: rev 3b0319ab090ec9c6285d49022398d93759637c49) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java > FSHLog may roll a new writer successfully with unflushed entries > ---------------------------------------------------------------- > > Key: HBASE-17206 > URL: https://issues.apache.org/jira/browse/HBASE-17206 > Project: HBase > Issue Type: Bug > Components: wal > Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4 > Reporter: Duo Zhang > Assignee: Duo Zhang > Priority: Critical > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.5, 1.1.8 > > Attachments: HBASE-17206.patch > > > Found it when debugging the flakey TestFailedAppendAndSync. > The problem is in waitSafePoint. > {code} > while (true) { > if (this.safePointAttainedLatch.await(1, TimeUnit.MILLISECONDS)) { > break; > } > if (syncFuture.isThrowable()) { > throw new FailedSyncBeforeLogCloseException(syncFuture.getThrowable()); > } > } > return syncFuture; > {code} > If we attach the safe point quick enough then we will bypass the syncFuture.isThrowable check and will not throw FailedSyncBeforeLogCloseException. > This may cause incosistency between memstore and wal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)