Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8B016200BE5 for ; Fri, 9 Dec 2016 11:26:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 881B1160B1D; Fri, 9 Dec 2016 10:26:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D005B160B1C for ; Fri, 9 Dec 2016 11:25:59 +0100 (CET) Received: (qmail 33422 invoked by uid 500); 9 Dec 2016 10:25:59 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 33388 invoked by uid 99); 9 Dec 2016 10:25:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2016 10:25:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BD2472C03E3 for ; Fri, 9 Dec 2016 10:25:58 +0000 (UTC) Date: Fri, 9 Dec 2016 10:25:58 +0000 (UTC) From: "ChiaPing Tsai (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17174) Use shared threadpool and AsyncProcess in BufferedMutatorImpl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 09 Dec 2016 10:26:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-17174?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D157= 34915#comment-15734915 ]=20 ChiaPing Tsai commented on HBASE-17174: --------------------------------------- [~anoop.hbase] [~yuzhihong@gmail.com] [~jinghe] If you have time, would you please help to review the v10 patch? Thanks a lot. > Use shared threadpool and AsyncProcess in BufferedMutatorImpl > ------------------------------------------------------------- > > Key: HBASE-17174 > URL: https://issues.apache.org/jira/browse/HBASE-17174 > Project: HBase > Issue Type: New Feature > Affects Versions: 2.0.0 > Reporter: ChiaPing Tsai > Assignee: ChiaPing Tsai > Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-17174.v0.patch, HBASE-17174.v1.patch, HBASE-17= 174.v10.patch, HBASE-17174.v2.patch, HBASE-17174.v3.patch, HBASE-17174.v4.p= atch, HBASE-17174.v5.patch, HBASE-17174.v6.patch, HBASE-17174.v7.patch, HBA= SE-17174.v8.patch, HBASE-17174.v9.patch > > > The following are reasons of reusing the pool and AP. > # A update-heavy application, for example, loader, creates many BufferedM= utator for batch updates. But these BufferedMutators can=E2=80=99t share a = large threadpool because the shutdown() method will be called when closing = any BufferedMutator. This patch adds a flag into BufferedMutatorParams for = preventing calling the shutdown() method in BufferedMutatorImpl#close > # The AsyncProcess has the powerful traffic control, but the control is a= gainst the single table currently. Because the AP is constructed at Buffere= dMutatorImpl's construction. This patch change the BufferedMutatorImpl's co= nstruction for reuse the AP so that the updates for different tables can be= restricted by the same AP. > Additionally, there are two changes(aren't included in latest patch) for = #2. > 1) The AP will be exposed to user. > 2) A new method will be added to Connection for instantiating a AP. > All suggestions are welcome. -- This message was sent by Atlassian JIRA (v6.3.4#6332)