Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 81BAE200BCE for ; Fri, 2 Dec 2016 17:20:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 80988160B08; Fri, 2 Dec 2016 16:20:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D48D8160B2B for ; Fri, 2 Dec 2016 17:20:00 +0100 (CET) Received: (qmail 53899 invoked by uid 500); 2 Dec 2016 16:19:59 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 53626 invoked by uid 99); 2 Dec 2016 16:19:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Dec 2016 16:19:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 5A23B2C1F5A for ; Fri, 2 Dec 2016 16:19:59 +0000 (UTC) Date: Fri, 2 Dec 2016 16:19:59 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17161) MOB : Make ref cell creation more efficient MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 02 Dec 2016 16:20:01 -0000 [ https://issues.apache.org/jira/browse/HBASE-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715536#comment-15715536 ] Hudson commented on HBASE-17161: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2059 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2059/]) HBASE-17161 MOB : Make ref cell creation more efficient. (anoopsamjohn: rev 4b3ffffa097e5a62063e6bc92bec63bcd91bbef6) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/HFileTestUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreFlusher.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HMobStore.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHMobStore.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TagUtil.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/ExtendedCell.java > MOB : Make ref cell creation more efficient > ------------------------------------------- > > Key: HBASE-17161 > URL: https://issues.apache.org/jira/browse/HBASE-17161 > Project: HBase > Issue Type: Improvement > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-17161.patch, HBASE-17161.patch, HBASE-17161_V2.patch, HBASE-17161_V2.patch > > > When we flush MOB data, ref cells are created per actual MOB cell. This creates lots of garbage > Refer MobUtils#createMobRefCell > We need to add 2 tags into the ref cell. An ArrayList is created with default size creating ref array. Call to CellUtil.getTags will create a new ArrayList even if the original cell is having no tags. > A new KV is created which will create a new backing byte[] and do copy. Also along with each of the flush/compaction op, a fresh Tag object is created for TableName tag. > Fixes include > 1. A table name tag is not going to change per HStore. Even both the new tags to be added. Will keep a byte[] of these 2 tags at MobHStore level so that all flush and compactions in this store can use it. > 2. Create a new MobRefCell just like TagRewriteCell where only value and tags part will be diff from the original cell. -- This message was sent by Atlassian JIRA (v6.3.4#6332)