Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0E76D200BE7 for ; Mon, 5 Dec 2016 18:07:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0D1BE160B27; Mon, 5 Dec 2016 17:07:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 81831160B18 for ; Mon, 5 Dec 2016 18:06:59 +0100 (CET) Received: (qmail 51025 invoked by uid 500); 5 Dec 2016 17:06:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 50979 invoked by uid 99); 5 Dec 2016 17:06:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Dec 2016 17:06:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 701BC2C2A68 for ; Mon, 5 Dec 2016 17:06:58 +0000 (UTC) Date: Mon, 5 Dec 2016 17:06:58 +0000 (UTC) From: "Josh Elser (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HBASE-13078) IntegrationTestSendTraceRequests is a noop MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 05 Dec 2016 17:07:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-13078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-13078. -------------------------------- Resolution: Fixed Fix Version/s: (was: 2.0.0) Best as I can tell, we landed the test fix on 1.0.x and 1.1.y here (no idea what the values of 'X' and 'Y' were when it first appeared anymore). HBASE-12938 was closed as "later" so the 0.98 branch changes can similarly be treated as "later". Closing this one to prevent later headache/confusion over what was done/needs to happen. > IntegrationTestSendTraceRequests is a noop > ------------------------------------------ > > Key: HBASE-13078 > URL: https://issues.apache.org/jira/browse/HBASE-13078 > Project: HBase > Issue Type: Test > Components: integration tests > Reporter: Nick Dimiduk > Assignee: Josh Elser > Priority: Critical > Attachments: HBASE-13078-0.98-removal.patch, HBASE-13078-0.98-v1.patch, HBASE-13078-v1.patch, HBASE-13078.patch > > > While pair-debugging with [~jeffreyz] on HBASE-13077, we noticed that IntegrationTestSendTraceRequests doesn't actually assert anything. This test should be converted to use a mini cluster, setup a POJOSpanReceiver, and then verify the spans collected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)