hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars George (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-17399) region_mover.rb uses different default filename, also needs slight change
Date Sat, 31 Dec 2016 15:43:58 GMT
Lars George created HBASE-17399:
-----------------------------------

             Summary: region_mover.rb uses different default filename, also needs slight change
                 Key: HBASE-17399
                 URL: https://issues.apache.org/jira/browse/HBASE-17399
             Project: HBase
          Issue Type: Bug
    Affects Versions: 1.3.0
            Reporter: Lars George


The command line help prints:

{noformat}
    -f, --filename=FILE           File to save regions list into unloading, \
        or read from loading; default /tmp/&lt;hostname:port&gt;
{noformat}

while in reality, the code does this:

{code}
def getFilename(options, targetServer, port)
  filename = options[:file]
  if not filename
    filename = "/tmp/" + ENV['USER'] + targetServer + ":" + port
  end
  return filename
end
{code}

An example for a generated file is:

{noformat}
/tmp/larsgeorgeslave-3.internal.larsgeorge.com\:16020
{noformat}

I suggest we fix the command line help explanation. But first, we should also fix how the
name is generated, *adding* a divider between the user name and the host name, and also change
how the port is attached to the host name. Currently this results in a rather strange {{\:}}
which could be hard to handle. Maybe we simply use an exclamation mark or hash for both? For
example:

{noformat}
/tmp/larsgeorge!slave-3.internal.larsgeorge.com!16020
/tmp/larsgeorge#slave-3.internal.larsgeorge.com#16020
{noformat}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message