hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17373) Reverse the order of snapshot creation in the CompactingMemStore
Date Wed, 28 Dec 2016 11:44:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15782728#comment-15782728
] 

Ted Yu commented on HBASE-17373:
--------------------------------

Please use parameterized tests for the different policies.

See TestHRegionServerBulkLoadWithOldSecureEndpoint.java for example of parameterized test.

swap() returns a boolean. Should this return value be checked in the caller ?

> Reverse the order of snapshot creation in the CompactingMemStore
> ----------------------------------------------------------------
>
>                 Key: HBASE-17373
>                 URL: https://issues.apache.org/jira/browse/HBASE-17373
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anastasia Braginsky
>            Assignee: Eshcar Hillel
>         Attachments: HBASE-17373-V01.patch
>
>
> In CompactingMemStore both in BASIC and EAGER cases when snapshot is created the segments
are first removed from the pipeline then added to the snapshot. This is the opposite to what
is done in the DefaultMemStore where the snapshot is firstly created with the active segment
and only after the active segment is refreshed. This JIRA is about to reverse the order in
CompactingMemStore and to make all MemStores to behave the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message