hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-17353) Cache famLen in OffheapKeyValue
Date Wed, 21 Dec 2016 06:57:58 GMT

     [ https://issues.apache.org/jira/browse/HBASE-17353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

ramkrishna.s.vasudevan updated HBASE-17353:
-------------------------------------------
    Attachment: HBASE-17353.patch

Attaching patch for reference. Will wait for discussion and if really needed will take this.
But in repeated runs now I can see that this OffheapKV#getFamilyLength() is coming at the
top of the profiler tool. 

> Cache famLen in OffheapKeyValue
> -------------------------------
>
>                 Key: HBASE-17353
>                 URL: https://issues.apache.org/jira/browse/HBASE-17353
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17353.patch, OffheapKV famLen cost.png
>
>
> WE need to discuss here. Already we had a TODO here. But this comes again after offheap
memstore is committed in trunk. 
> Attaching a screenshot to show the impact. True that these changes won't have a direct
impact on the final perf but at micro level they would have. 
> In case of KeyValue it is just retrieving a byte from the byte[] (o(1) access).
> But here we need to access the memory to retrive that one byte though it is Unsafe based.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message