hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17347) ExportSnapshot may write snapshot info file to wrong directory when specifying target name
Date Wed, 21 Dec 2016 02:02:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765857#comment-15765857
] 

Hudson commented on HBASE-17347:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-1.4 #573 (See [https://builds.apache.org/job/HBase-1.4/573/])
HBASE-17347 ExportSnapshot may write snapshot info file to wrong (tedyu: rev fa975fa3829fd7182896ece7f8a4951e7ca7bed4)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java


> ExportSnapshot may write snapshot info file to wrong directory when specifying target
name
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17347
>                 URL: https://issues.apache.org/jira/browse/HBASE-17347
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 2.0.0
>            Reporter: Jianwei Cui
>            Assignee: Jianwei Cui
>            Priority: Minor
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-17347-v1.patch
>
>
> Exportsnapshot will write a new snapshot info file when specifying the target name:
> {code}
>     if (!targetName.equals(snapshotName)) {
>       SnapshotDescription snapshotDesc =
>         SnapshotDescriptionUtils.readSnapshotInfo(inputFs, snapshotDir)
>           .toBuilder()
>           .setName(targetName)
>           .build();
>       SnapshotDescriptionUtils.writeSnapshotInfo(snapshotDesc, snapshotTmpDir, outputFs);
>     }
> {code}
> The snapshot info file will be written to the snapshot tmp directory, however, it should
be directly written to the snapshot directory if {{snapshot.export.skip.tmp}} is true. In
addition, owner and permission should be set for the new snapshot info file when needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message