hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17346) Add coprocessor service support
Date Wed, 28 Dec 2016 22:44:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783892#comment-15783892
] 

stack commented on HBASE-17346:
-------------------------------

bq. I think we need to redesign the API.

Which API boss?

bq. The old implementation is a little confusing to me.

Nod. Understood. But in the end I found it coheres.... it makes some sense.

bq. We have an AggregationClient but marked as InterfaceAudience.Private?

Yes. It looks like the below cleanup project changed it from pubilc, evolving, which makes
more sense:

commit cd63f2055e001e9b3063676cf75b471eae9b3d75
Author: Jonathan Hsieh <jmhsieh@apache.org>
Date:   Mon Sep 16 05:18:27 2013 +0000

    HBASE-9529 Audit of hbase-client @InterfaceAudience.Public apis

This client used to live inside in hbase-client (or hbase-server, I don't remember which)
so the intent was probably to shutdown access generally and in this case, on a little used
endpoint.

Now this client has been moved out to hbase-endpoint and it is a canonical illustration of
how to do a coprocessor, we could change the audience back to public?

On use of ServerRpcController, that looks like lazyness (on my part I think).

Attaching a patch that cleans up the audience and that makes a local RpcController for use
by this Endpoint. Looking at the endpoint utility methods, we seem to do the right thing if
it is a base RpcController and not a ServerRpcController.

On retrying, yeah, looks like none implemented.

Thanks [~Apache9]




> Add coprocessor service support
> -------------------------------
>
>                 Key: HBASE-17346
>                 URL: https://issues.apache.org/jira/browse/HBASE-17346
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Duo Zhang
>             Fix For: 2.0.0
>
>
> I think we need to redesign the API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message