hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17336) get/update replication peer config requests should be routed through master
Date Wed, 28 Dec 2016 20:07:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783614#comment-15783614
] 

Enis Soztutar commented on HBASE-17336:
---------------------------------------

There is a copy-paste error below, should call the post method. 
{code}
+  public void postGetReplicationPeerConfig(final String peerId) throws IOException {
+    execOperation(coprocessors.isEmpty() ? null : new CoprocessorOperation() {
+      @Override
+      public void call(MasterObserver observer, ObserverContext<MasterCoprocessorEnvironment>
ctx)
+          throws IOException {
+        observer.preGetReplicationPeerConfig(ctx, peerId);
+      }
+    });
+  }
{code}

Same thing in the postUpdateReplicationPeerConfig. 

This is not in this patch, but maybe we should do a follow up patch in the parent to move
ReplicationPeer and other replication related PB messages to the replication.proto from zookeeper.proto.


In ServerRegionReplicaUtil, you could have also switched to using Admin, rather than RA. Not
critical for this patch though. Maybe after all methods moved to Admin, we can do a refactor
patch to convert internal usages from RA to Admin. 

Looks great otherwise. 

> get/update replication peer config requests should be routed through master
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-17336
>                 URL: https://issues.apache.org/jira/browse/HBASE-17336
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17336-v1.patch, HBASE-17336-v2.patch, HBASE-17336-v3.patch,
HBASE-17336-v4.patch
>
>
> As HBASE-11392 description says, we should move replication operations to be routed through
master.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message