hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17334) Add locate row before/after support for AsyncRegionLocator
Date Wed, 21 Dec 2016 18:30:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767773#comment-15767773

stack commented on HBASE-17334:

Skimmed. LGTM. I like the enum for what type of location.

Below are nits that can be addressed on commit or in next patch... 

It just gets a bit confusing when you add a shortcut for 'before'

      this.before = before;

... rather than do test of the enum if == BEFORE.

nit: do a switch in stead of if/else:

    if (type == RegionLocateType.BEFORE) {

RegionLocateType is a nice improvement.

> Add locate row before/after support for AsyncRegionLocator
> ----------------------------------------------------------
>                 Key: HBASE-17334
>                 URL: https://issues.apache.org/jira/browse/HBASE-17334
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>         Attachments: HBASE-17334-v1.patch, HBASE-17334.patch
> Now we only have a getPreviousRegionLocation method which is only used for reverse scan,
and it is not perfect as it can not deal with region merge. As we want to add inclusive/exclusive
support for start row and end row of a scan, we need to implement general locate to row before/after
method for AsyncRegionLocator.

This message was sent by Atlassian JIRA

View raw message