hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "binlijin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17332) Replace HashMap to Array for DataBlockEncoding.idToEncoding
Date Mon, 19 Dec 2016 02:35:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15759941#comment-15759941
] 

binlijin commented on HBASE-17332:
----------------------------------

There is no much different for the E2E QPS, but we can see with the patch this method is not
hot method any more.

> Replace HashMap to Array for DataBlockEncoding.idToEncoding
> -----------------------------------------------------------
>
>                 Key: HBASE-17332
>                 URL: https://issues.apache.org/jira/browse/HBASE-17332
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: binlijin
>            Assignee: binlijin
>             Fix For: 2.0.0
>
>         Attachments: DBE.idToEncoding.png, DBE.idToEncoding_afterOptimize.png, HBASE-17332.patch
>
>
> Array is faster than HashMap also no need to autoboxing.
> I can see the DataBlockEncoding#getDataBlockEncoderById is a hot method if enable encoding
in my perf test(Random read, all data cache in LruBlockCache). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message