hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anastasia Braginsky (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17291) Remove ImmutableSegment#getKeyValueScanner
Date Mon, 26 Dec 2016 11:34:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15778175#comment-15778175
] 

Anastasia Braginsky commented on HBASE-17291:
---------------------------------------------

Thanks [~ram_krish]!
1. I understand now where the close of the SnapshotScanner happens.
2. I do not need more time with HBASE-17081 unless some unpredictable last minute issues will
be shown up.

I hope we will be able to commit HBASE-17081 soon and just after this fix.

> Remove ImmutableSegment#getKeyValueScanner
> ------------------------------------------
>
>                 Key: HBASE-17291
>                 URL: https://issues.apache.org/jira/browse/HBASE-17291
>             Project: HBase
>          Issue Type: Improvement
>          Components: Scanners
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17291.patch, HBASE-17291_1.patch, HBASE-17291_2.patch
>
>
> This is based on a discussion over [~anastas]'s patch. The MemstoreSnapshot uses a KeyValueScanner
which actually seems redundant considering we already have a SegmentScanner. The idea is that
the snapshot scanner should be a simple iterator type of scanner but it lacks the capability
to do the reference counting on that segment that is now used in snapshot. With snapshot having
mulitple segments in the latest impl it is better we hold on to the segment by doing ref counting.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message