hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "huaxiang sun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17249) Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange reference as the parameter instead of creating a new setColumnFamilyTimeRange instance
Date Mon, 05 Dec 2016 23:02:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723655#comment-15723655
] 

huaxiang sun commented on HBASE-17249:
--------------------------------------

Hi [~anoop.hbase], just want to point out for cases like below, the key is not cloned and
hold reference to entry.getKey(). Think that this needs to be cleaned in the future, thanks
for the review.

https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java#L131

> Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange reference as
the parameter instead of creating a new setColumnFamilyTimeRange instance
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17249
>                 URL: https://issues.apache.org/jira/browse/HBASE-17249
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>            Priority: Minor
>         Attachments: HBASE-17249-master-001.patch, HBASE-17249-master-002.patch
>
>
> Going through the code, found For Get/Scan's setTimeRange/setColumnFamilyTimeRange, it
can use  TimeRange as reference instead of creating a new one.
> Reference:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L500
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L506
> We can implement this in a similar way as filter:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L510
> I checked it is same with branch-1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message