hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17249) Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange reference as the parameter instead of creating a new setColumnFamilyTimeRange instance
Date Mon, 05 Dec 2016 08:08:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15721546#comment-15721546
] 

Anoop Sam John commented on HBASE-17249:
----------------------------------------

+1 for the changes in PBUtil. Make sense.
For construction of Scan/ Get from another object, it might be better that the new objs refer
to new cloned member variable instances instances.  You can see attributes map etc, we dont
directly refer to the Map of the passed param object.  Ya there also some inconsistency as
u pointed out (Filter case etc).. Still I feel current way is ok.  PB Util change make all
sense.

> Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange reference as
the parameter instead of creating a new setColumnFamilyTimeRange instance
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17249
>                 URL: https://issues.apache.org/jira/browse/HBASE-17249
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>            Priority: Minor
>         Attachments: HBASE-17249-master-001.patch
>
>
> Going through the code, found For Get/Scan's setTimeRange/setColumnFamilyTimeRange, it
can use  TimeRange as reference instead of creating a new one.
> Reference:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L500
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L506
> We can implement this in a similar way as filter:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L510
> I checked it is same with branch-1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message