hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17239) Add UnsafeByteOperations#wrap(ByteInput, int offset, int len) API
Date Mon, 05 Dec 2016 15:50:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15722583#comment-15722583
] 

Hudson commented on HBASE-17239:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2077 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2077/])
HBASE-17239 Add UnsafeByteOperations#wrap(ByteInput, int offset, int (ramkrishna: rev 94302a3d26702b4ba07af76bf249298edf9118e4)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* (edit) hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/com/google/protobuf/CodedInputStream.java
* (edit) hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/com/google/protobuf/UnsafeByteOperations.java
* (add) hbase-protocol-shaded/src/main/patches/HBASE-17239.patch


> Add UnsafeByteOperations#wrap(ByteInput, int offset, int len) API
> -----------------------------------------------------------------
>
>                 Key: HBASE-17239
>                 URL: https://issues.apache.org/jira/browse/HBASE-17239
>             Project: HBase
>          Issue Type: Improvement
>          Components: Protobufs
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17239_V1.patch, HBASE-17239_V2.patch, HBASE-17239_V3.patch
>
>
> Instead of exposing the newInstance(ByteInput, boolean) in CIS we could just add a UnsafeByteOperations#wrap(ByteInput,
offset, len). And we could just call that and do a #newcodedInput() over that. So internally
we do return a immutable version of the ByteInput only. This way we can avoid CIS#newInstance(ByteInput)
exposure and can keep it package private as done in COS. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message