hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17237) Override the correct compact method in HMobStore
Date Tue, 06 Dec 2016 11:11:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724853#comment-15724853
] 

Anoop Sam John commented on HBASE-17237:
----------------------------------------

+1
How u noticed this Jingcheng?
This way of overriding a method and super method gets deprecated against a new method, can
cause issues later also..
One thing we need to enforce is that , while we deprecate one method, we need to look in our
own code base and make no where we rely on that.. All places, we have to move to new method.
Just doing some random looks, we have many such old refs to deprecated methods I believe..
 May be we should do a clean up before 2.0.   
These are not related to this patch.. Just saying as it is a related issue..  This was a nice
catch man.

> Override the correct compact method in HMobStore
> ------------------------------------------------
>
>                 Key: HBASE-17237
>                 URL: https://issues.apache.org/jira/browse/HBASE-17237
>             Project: HBase
>          Issue Type: Bug
>          Components: mob
>            Reporter: Jingcheng Du
>            Assignee: Jingcheng Du
>         Attachments: HBASE-17237.patch
>
>
> The method Store#compact(CompactionContext compaction, ThroughputController throughputController)
is deprecated now, and HMobStore overrides it. HMobStore needs to override compact(CompactionContext
compaction, ThroughputController throughputController, User user) instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message