hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17235) Improvement in creation of CIS for onheap buffer cases
Date Fri, 02 Dec 2016 07:47:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714359#comment-15714359
] 

Anoop Sam John commented on HBASE-17235:
----------------------------------------

This is not so minor IMO. :-)  So changed the subject and priority.. I noticed this but was
wondering why PB not exposed.  Thought of checking this later but just forgot. Thanks for
the nice catch

> Improvement in creation of CIS for onheap buffer cases
> ------------------------------------------------------
>
>                 Key: HBASE-17235
>                 URL: https://issues.apache.org/jira/browse/HBASE-17235
>             Project: HBase
>          Issue Type: Improvement
>          Components: rpc
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17235.patch
>
>
> {code}
>       if (buf.hasArray()) {
>         cis = CodedInputStream.newInstance(buf.array(), offset, buf.limit());
>       } else {
> {code}
> Currently we do this for onheap buffers incase there is no reservoir or the size is less
than the minSizeforReservoir. I could see that even if reservoir is there there are requests
which goes with the above way of creating CIS. This could be made efficient to avoid underlying
copies by just doing this
> {code}
> cis = UnsafeByteOperations.unsafeWrap(buf.array(), offset, buf.limit()).newCodedInput();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message