hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17228) precommit grep -c ERROR may grab non errors
Date Fri, 02 Dec 2016 15:20:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715392#comment-15715392

Matteo Bertozzi commented on HBASE-17228:

yeah, I think the patch it's ok. I did a quick check and it looks like the errors are around
the only thing it seems that we end up with too many errors, but that it was also true before.
for example a simple typo in one protobuf line gives me 36 error, all marked as \[ERROR\].
[ERROR] PROTOC FAILED: [libprotobuf WARNING google/protobuf/compiler/parser.cc:546] No syntax
specified for the proto file: Admin.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";'
to specify a syntax version. (Defaulted to proto2 syntax.)
[ERROR] Failed to execute goal org.xolstice.maven.plugins:protobuf-maven-plugin:0.5.0:compile
(compile-protoc) on project hbase-protocol-shaded: protoc did not exit cleanly. Review output
for more information. -> [Help 1]

> precommit grep -c ERROR may grab non errors
> -------------------------------------------
>                 Key: HBASE-17228
>                 URL: https://issues.apache.org/jira/browse/HBASE-17228
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Matteo Bertozzi
>            Priority: Minor
>         Attachments: HBASE-17228.master.001.patch
> it looks like that we do a simple "grep -c ERROR" to count the errors that we have from
the build.
> https://github.com/apache/hbase/blob/master/dev-support/hbase-personality.sh#L305
> but in this way we ended up with a count=1 just because we have one enum called ERROR_CODE
in hbase. and the enum shows up as debug message
> {noformat}
> $ grep ERROR patch-hbaseprotoc-hbase-server.txt 
> [DEBUG] adding entry org/apache/hadoop/hbase/util/HBaseFsck$ErrorReporter$ERROR_CODE.class
> {noformat}

This message was sent by Atlassian JIRA

View raw message