hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jerry He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17221) Abstract out an interface for RpcServer.Call
Date Sun, 04 Dec 2016 01:44:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15719089#comment-15719089
] 

Jerry He commented on HBASE-17221:
----------------------------------

Yes. @stack.  I follow you, and had the same thinking.
I wondered if I could get rid of getHeader  (request header) from the interface because we
have all things in the Header already (priority, timeout, etc). But there are places that
take the Header as param just to get the Priority.  Changing these places may raise backward
compatibility questions.  The
{noformat}
@InterfaceAudience.LimitedPrivate({HBaseInterfaceAudience.COPROC, HBaseInterfaceAudience.PHOENIX})
{noformat}
is the problem.


> Abstract out an interface for RpcServer.Call
> --------------------------------------------
>
>                 Key: HBASE-17221
>                 URL: https://issues.apache.org/jira/browse/HBASE-17221
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jerry He
>            Assignee: Jerry He
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17221-v2.patch, HBASE-17221-v3.patch, HBASE-17221.patch
>
>
> RpcServer.Call is a concrete class, but it is marked as:
> {noformat}
> @InterfaceAudience.LimitedPrivate({HBaseInterfaceAudience.COPROC, HBaseInterfaceAudience.PHOENIX})
> {noformat}
> Let's abstract out an interface out of it for potential consumers that want to pass it
around.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message