hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17218) [C++] Use Google Style guide and cpplint
Date Fri, 30 Dec 2016 00:59:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786543#comment-15786543
] 

Hadoop QA commented on HBASE-17218:
-----------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m 32s {color} | {color:blue}
Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 7s {color} | {color:blue}
Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} |
{color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 2s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 4s {color}
| {color:green} The patch generated 0 new + 435 unchanged - 1 fixed = 435 total (was 436)
{color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 27m 7s {color}
| {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2
2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 3s {color}
| {color:green} the patch passed {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 56s {color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-12-30 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12845126/HBASE-17218.HBASE-14850.v2.patch
|
| JIRA Issue | HBASE-17218 |
| Optional Tests |  shellcheck  shelldocs  |
| uname | Linux 463560ef2ea1 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | HBASE-14850 / 5459e0d |
| shellcheck | v0.4.5 |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/5091/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> [C++] Use Google Style guide and cpplint
> ----------------------------------------
>
>                 Key: HBASE-17218
>                 URL: https://issues.apache.org/jira/browse/HBASE-17218
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Sudeep Sunthankar
>             Fix For: HBASE-14850
>
>         Attachments: HBASE-17218.HBASE-14850.v2.patch, HBASE-17218_v1.patch
>
>
> This was discussed elsewhere in other sub jiras. Let's use the Google's Style guide going
forward (instead of LLVM one). 
> There is an Eclipse formatter, a cpplint script and clang-format integration https://github.com/google/styleguide.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message