hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17191) Make use of UnsafeByteOperations#unsafeWrap(ByteBuffer buffer) in PBUtil#toCell(Cell cell)
Date Thu, 01 Dec 2016 12:07:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711807#comment-15711807
] 

ramkrishna.s.vasudevan commented on HBASE-17191:
------------------------------------------------

Now the next thing is that in order to check for ByteBufferCell or not we cannot add it in
CellUtil because hbase-common does not know about hbase-shaded-protobuf.
Is it ok if we directly add in ProtobufUtil#toCell in hbase-shaded-protobuf package?

> Make use of UnsafeByteOperations#unsafeWrap(ByteBuffer buffer) in PBUtil#toCell(Cell
cell)
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17191
>                 URL: https://issues.apache.org/jira/browse/HBASE-17191
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>
> Since we now have support for BBs in UnsafeByteOperations#unsafeWrap(ByteBuffer) . So
for the non - java clients while creating the PB result we could avoid the copy to an temp
array. 
> Since we have a support to write to BB in ByteOutput having a result backed by Bytebuffer
should be fine. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message