hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anastasia Braginsky (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17081) Flush the entire CompactingMemStore content to disk
Date Wed, 14 Dec 2016 09:02:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747744#comment-15747744

Anastasia Braginsky commented on HBASE-17081:

[~stack], thank you for your comments, here are my answers:

bq. Are we going to have an if/else per flush policy

We would prefer to leave the if-else statement whether to flush everything or not. Although
currently we always flushing everything (using composite snapshot). Under HBASE-16417, Eshcar
is still running more experiments to find the best policy. So maybe it will be needed there.
If not, it can be removed as part of HBASE-16417.

bq. Can you presize the Array?

Yes, I can presize the Array. However it would be a pity, to create now a new patch just for
that. Please let me add this in using my next JIRA.

bq. As said before, this is expensive... 

TimeRangeTracker is requested by MemStoreSnapshot and is later used by the DefaultMobStoreFlusher.
Maybe it can be anyhow avoided, but I didn't look so deep. As TimeRangeTracker was initially
part of the snapshot, I left it there. It can be removed by another JIRA if indeed unneeded...

[~anoop.hbase], it looks like everybody are waiting for your blessing! :)

> Flush the entire CompactingMemStore content to disk
> ---------------------------------------------------
>                 Key: HBASE-17081
>                 URL: https://issues.apache.org/jira/browse/HBASE-17081
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anastasia Braginsky
>            Assignee: Anastasia Braginsky
>         Attachments: HBASE-15787_8.patch, HBASE-17081-V01.patch, HBASE-17081-V02.patch,
HBASE-17081-V03.patch, HBASE-17081-V04.patch, HBASE-17081-V05.patch, HBASE-17081-V06.patch,
HBASE-17081-V06.patch, HBaseMeetupDecember2016-V02.pptx, Pipelinememstore_fortrunk_3.patch
> Part of CompactingMemStore's memory is held by an active segment, and another part is
divided between immutable segments in the compacting pipeline. Upon flush-to-disk request
we want to flush all of it to disk, in contrast to flushing only tail of the compacting pipeline.

This message was sent by Atlassian JIRA

View raw message