Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BFFB4200BE2 for ; Wed, 30 Nov 2016 14:36:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id BED34160B21; Wed, 30 Nov 2016 13:36:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 41487160B19 for ; Wed, 30 Nov 2016 14:36:03 +0100 (CET) Received: (qmail 92429 invoked by uid 500); 30 Nov 2016 13:36:01 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 92300 invoked by uid 99); 30 Nov 2016 13:35:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2016 13:35:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 611A32C03DB for ; Wed, 30 Nov 2016 13:35:58 +0000 (UTC) Date: Wed, 30 Nov 2016 13:35:58 +0000 (UTC) From: "Duo Zhang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HBASE-17206) FSHLog may roll a new writer successfully with unflushed entries MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 30 Nov 2016 13:36:03 -0000 Duo Zhang created HBASE-17206: --------------------------------- Summary: FSHLog may roll a new writer successfully with unflushed entries Key: HBASE-17206 URL: https://issues.apache.org/jira/browse/HBASE-17206 Project: HBase Issue Type: Bug Components: wal Affects Versions: 2.0.0, 1.4.0 Reporter: Duo Zhang Assignee: Duo Zhang Priority: Critical Fix For: 2.0.0, 1.4.0 Found it when debugging the flakey TestFailedAppendAndSync. The problem is in waitSafePoint. {code} while (true) { if (this.safePointAttainedLatch.await(1, TimeUnit.MILLISECONDS)) { break; } if (syncFuture.isThrowable()) { throw new FailedSyncBeforeLogCloseException(syncFuture.getThrowable()); } } return syncFuture; {code} If we attach the safe point quick enough then we will bypass the syncFuture.isThrowable check and will not throw FailedSyncBeforeLogCloseException. This may cause incosistency between memstore and wal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)