Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 707D5200BF0 for ; Thu, 24 Nov 2016 19:17:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6F46F160B1E; Thu, 24 Nov 2016 18:17:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B5FF7160B1F for ; Thu, 24 Nov 2016 19:16:59 +0100 (CET) Received: (qmail 50215 invoked by uid 500); 24 Nov 2016 18:16:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 49968 invoked by uid 99); 24 Nov 2016 18:16:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Nov 2016 18:16:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6ECA92C03E7 for ; Thu, 24 Nov 2016 18:16:58 +0000 (UTC) Date: Thu, 24 Nov 2016 18:16:58 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 24 Nov 2016 18:17:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-17174?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D156= 93948#comment-15693948 ]=20 Anoop Sam John edited comment on HBASE-17174 at 11/24/16 6:16 PM: ------------------------------------------------------------------ That is a wrong expectation itself IMO. :-) The pool is created by some ot= her code and been passed.. So the other part of code should be doing the po= ol close after the BufferedMutator close. See how we handle similar scenario in HTable {code} this.pool =3D pool; if (pool =3D=3D null) { this.pool =3D getDefaultExecutor(this.configuration); this.cleanupPoolOnClose =3D true; } else { this.cleanupPoolOnClose =3D false; } {code} When user passed a pool, we will never close it as part of HTable#close. was (Author: anoop.hbase): That is a wrong expectation itself IMO. :-) The pool is created by some ot= her code and been passed.. So the other part of code should be doing the po= ol close after the BufferedMutator close. > Use shared threadpool in BufferedMutatorImpl > -------------------------------------------- > > Key: HBASE-17174 > URL: https://issues.apache.org/jira/browse/HBASE-17174 > Project: HBase > Issue Type: New Feature > Affects Versions: 2.0.0 > Reporter: ChiaPing Tsai > Assignee: ChiaPing Tsai > Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-17174.v0.patch, HBASE-17174.v1.patch > > > A update-heavy application, for example, loader, creates many BufferedMut= ator for batch updates. But these BufferedMutators can=E2=80=99t share a la= rge threadpool because the shutdown() method will be called when closing an= y BufferedMutator. This patch adds a flag into BufferedMutatorParams for pr= eventing calling the shutdown() method in BufferedMutatorImpl#close -- This message was sent by Atlassian JIRA (v6.3.4#6332)