Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 21 Nov 2016 09:01:16 +0000 (UTC)
From: "Guanghao Zhang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13022129.1479718807000.325473.1479718876123@Atlassian.JIRA>
In-Reply-To: <JIRA.13022129.1479718807000@Atlassian.JIRA>
References: <JIRA.13022129.1479718807000@Atlassian.JIRA> <JIRA.13022129.1479718807825@arcas>
Subject: [jira] [Created] (HBASE-17140) Throw RegionOfflineException
 directly when request for a disabled table
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 21 Nov 2016 09:01:18 -0000

Guanghao Zhang created HBASE-17140:
--------------------------------------

             Summary: Throw RegionOfflineException directly when request for a disabled table
                 Key: HBASE-17140
                 URL: https://issues.apache.org/jira/browse/HBASE-17140
             Project: HBase
          Issue Type: Improvement
          Components: Client
            Reporter: Guanghao Zhang


Now when request for a disabled table, it need 3 rpc call before fail.
1. get region location
2. send call to rs and get NotServeRegionException
3. retry and check the table state, then throw TableNotEnabledException

The table state check is added for disabled table. But now the prepare method in RegionServerCallable shows that all retry request will get table state first.
{code}
public void prepare(final boolean reload) throws IOException {
    // check table state if this is a retry
    if (reload && !tableName.equals(TableName.META_TABLE_NAME) &&
        getConnection().isTableDisabled(tableName)) {
      throw new TableNotEnabledException(tableName.getNameAsString() + " is disabled.");
    }
    try (RegionLocator regionLocator = connection.getRegionLocator(tableName)) {
      this.location = regionLocator.getRegionLocation(row);
    }
    if (this.location == null) {
      throw new IOException("Failed to find location, tableName=" + tableName +
          ", row=" + Bytes.toString(row) + ", reload=" + reload);
    }
    setStubByServiceName(this.location.getServerName());
}
{code}

An improvement is set the region offline in HRegionInfo. Then throw the RegionOfflineException when get region location.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)