Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1EFC5200BD4 for ; Thu, 17 Nov 2016 04:38:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1D455160B17; Thu, 17 Nov 2016 03:38:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8C7BC160B08 for ; Thu, 17 Nov 2016 04:37:59 +0100 (CET) Received: (qmail 45618 invoked by uid 500); 17 Nov 2016 03:37:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 45587 invoked by uid 99); 17 Nov 2016 03:37:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Nov 2016 03:37:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6FC972C4C73 for ; Thu, 17 Nov 2016 03:37:58 +0000 (UTC) Date: Thu, 17 Nov 2016 03:37:58 +0000 (UTC) From: "Phil Yang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17112) Prevent setting timestamp of delta operations being same as previous value's MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 17 Nov 2016 03:38:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-17112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672584#comment-15672584 ] Phil Yang commented on HBASE-17112: ----------------------------------- I think so. In Append#add and Increment#addColumn we can pass cf/cq/delta but can not pass ts, or pass a Cell but server will ignore its ts. > Prevent setting timestamp of delta operations being same as previous value's > ---------------------------------------------------------------------------- > > Key: HBASE-17112 > URL: https://issues.apache.org/jira/browse/HBASE-17112 > Project: HBase > Issue Type: Bug > Affects Versions: 1.1.7, 0.98.23, 1.2.4 > Reporter: Phil Yang > Assignee: Phil Yang > Attachments: HBASE-17112-v1.patch, HBASE-17112-v2.patch > > > In delta operations, Increment and Append. We will read current value first and then write the new whole result into WAL as the type of Put with current timestamp. If the previous ts is larger than current ts, we will use the previous ts. > If we have two Puts with same TS, we will ignore the Put with lower sequence id. It is not friendly with versioning. And for replication we will drop sequence id while writing to peer cluster so in the slave we don't know what the order they are being written. If the pushing is disordered, the result will be wrong. > We can set the new ts to previous+1 if the previous is not less than now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)