Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 78B1B200BCC for ; Tue, 15 Nov 2016 01:39:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 777DB160B06; Tue, 15 Nov 2016 00:39:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D0132160B0F for ; Tue, 15 Nov 2016 01:38:59 +0100 (CET) Received: (qmail 4578 invoked by uid 500); 15 Nov 2016 00:38:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 4358 invoked by uid 99); 15 Nov 2016 00:38:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Nov 2016 00:38:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 829742C4C77 for ; Tue, 15 Nov 2016 00:38:58 +0000 (UTC) Date: Tue, 15 Nov 2016 00:38:58 +0000 (UTC) From: "Duo Zhang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17085) AsyncFSWAL may issue unnecessary AsyncDFSOutput.sync MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 15 Nov 2016 00:39:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-17085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665544#comment-15665544 ] Duo Zhang commented on HBASE-17085: ----------------------------------- If there is no operation after the sync, then the newHighestProcessedAppendTxid will always be 1 and the sync will never be finished? > AsyncFSWAL may issue unnecessary AsyncDFSOutput.sync > ---------------------------------------------------- > > Key: HBASE-17085 > URL: https://issues.apache.org/jira/browse/HBASE-17085 > Project: HBase > Issue Type: Sub-task > Components: wal > Affects Versions: 2.0.0 > Reporter: Duo Zhang > Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17085-v1.patch, HBASE-17085-v2.patch, HBASE-17085.patch > > > The problem is in appendAndSync method, we will issue an AsyncDFSOutput.sync if syncFutures is not empty. The SyncFutures in syncFutures can only be removed after an AsyncDFSOutput.sync comes back, so before the AsyncDFSOutput.sync actually returns, we will always issue an AsyncDFSOutput.sync after an append even if there is no new sync request. -- This message was sent by Atlassian JIRA (v6.3.4#6332)