Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E340A200BB7 for ; Wed, 9 Nov 2016 13:21:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E2077160B15; Wed, 9 Nov 2016 12:21:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 63583160AFD for ; Wed, 9 Nov 2016 13:21:59 +0100 (CET) Received: (qmail 94346 invoked by uid 500); 9 Nov 2016 12:21:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 94318 invoked by uid 99); 9 Nov 2016 12:21:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Nov 2016 12:21:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 656262C1F54 for ; Wed, 9 Nov 2016 12:21:58 +0000 (UTC) Date: Wed, 9 Nov 2016 12:21:58 +0000 (UTC) From: "Duo Zhang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17053) Remove LogRollerExitedChecker MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 09 Nov 2016 12:22:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-17053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15650783#comment-15650783 ] Duo Zhang commented on HBASE-17053: ----------------------------------- Yes it calls logRolled.close when exiting in the run method, and also for WALPE. Let me check the timed out tests. > Remove LogRollerExitedChecker > ----------------------------- > > Key: HBASE-17053 > URL: https://issues.apache.org/jira/browse/HBASE-17053 > Project: HBase > Issue Type: Sub-task > Components: wal > Affects Versions: 2.0.0 > Reporter: Duo Zhang > Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17053-v1.patch, HBASE-17053.patch > > > Now the LogRoll may exit before WAL exit but we will still write some close event to WAL when shutting down RS. And for AsyncFSWAL, we will open a new wal writer when error occur. If LogRoller has already exited then AsyncFSWAL will wait for ever and cause RS to hang. > It does not make sense to quit LogRoller ahead of WAL, this jira aims to change the shutdown order. -- This message was sent by Atlassian JIRA (v6.3.4#6332)