Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 7 Nov 2016 08:02:58 +0000 (UTC)
From: "Duo Zhang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13018683.1478441134000.206916.1478505778506@Atlassian.JIRA>
In-Reply-To: <JIRA.13018683.1478441134000@Atlassian.JIRA>
References: <JIRA.13018683.1478441134000@Atlassian.JIRA> <JIRA.13018683.1478441134034@arcas>
Subject: [jira] [Commented] (HBASE-17035) Check why we roll a wal writer at
 10MB when the configured roll size is 120M+ with AsyncFSWAL
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 07 Nov 2016 08:03:00 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643441#comment-15643441 ] 

Duo Zhang commented on HBASE-17035:
-----------------------------------

No.

The waitForSafePoint is used to confirm that all out-going data have been acked, which means there will be no synccompleted after we return from waitForSafePoint and before the switch of writer. And the doReplaceWriter is protected by rollWriterLock, so it is impossible that we request a log roll again when there is a doReplaceWriter actively running.

> Check why we roll a wal writer at 10MB when the configured roll size is 120M+ with AsyncFSWAL
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17035
>                 URL: https://issues.apache.org/jira/browse/HBASE-17035
>             Project: HBase
>          Issue Type: Sub-task
>          Components: wal
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>
> Found this when addressing HBASE-16890. It is one of the possible reason that why AsyncFSWAL performs worse than FSHLog when running PE tool.
> https://issues.apache.org/jira/browse/HBASE-16890?focusedCommentId=15636688&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15636688


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)