Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 5 Nov 2016 00:04:59 +0000 (UTC)
From: "Enis Soztutar (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13017778.1478197788000.196420.1478304299638@Atlassian.JIRA>
In-Reply-To: <JIRA.13017778.1478197788000@Atlassian.JIRA>
References: <JIRA.13017778.1478197788000@Atlassian.JIRA> <JIRA.13017778.1478197788842@arcas>
Subject: [jira] [Commented] (HBASE-17016) Reimplement per-region latency
 histogram metrics
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 05 Nov 2016 00:05:01 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15638127#comment-15638127 ] 

Enis Soztutar commented on HBASE-17016:
---------------------------------------

bq. If we can bring them back, and they are cheap - sure, why not.
Fair enough. 

bq. If we find out that any latency histograms are relatively expensive (in some visible form) I'd be in favor or removing them, unless someone has the usecase when they are actually useful.
I think the findings at HBASE-17017 justifies the removal, other than object allocation, there is 17% perf boost with basic testing. We can only bring them back if we do the same test with a new patch and there is no impact for the same test (both object allocation, and perf impact).  

> Reimplement per-region latency histogram metrics
> ------------------------------------------------
>
>                 Key: HBASE-17016
>                 URL: https://issues.apache.org/jira/browse/HBASE-17016
>             Project: HBase
>          Issue Type: Task
>          Components: metrics
>    Affects Versions: 2.0.0, 1.4.0
>            Reporter: Andrew Purtell
>             Fix For: 2.0.0, 1.4.0
>
>
> Follow up from HBASE-10656, where [~enis] says:
> {quote}
> the main problem is that we have A LOT of per-region metrics that are latency histograms. These latency histograms create many many Counter / LongAdder objects. We should get rid of per-region latencies and maybe look at reducing the per-region metric overhead.
> {quote}
> And [~ghelmling] gives us a good candidate to implement pre-region latency histograms [HdrHistogram|https://github.com/HdrHistogram/HdrHistogram].
> Let's consider removing the per-region latency histograms and reimplement using HdrHistogram.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)