Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EC722200BC7 for ; Fri, 25 Nov 2016 09:47:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EB0B6160B22; Fri, 25 Nov 2016 08:47:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 64538160AF6 for ; Fri, 25 Nov 2016 09:47:00 +0100 (CET) Received: (qmail 62404 invoked by uid 500); 25 Nov 2016 08:46:59 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 62384 invoked by uid 99); 25 Nov 2016 08:46:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Nov 2016 08:46:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6A5342C03DF for ; Fri, 25 Nov 2016 08:46:59 +0000 (UTC) Date: Fri, 25 Nov 2016 08:46:59 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-17012) Handle Offheap cells in CompressedKvEncoder MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 25 Nov 2016 08:47:01 -0000 [ https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-17012: ------------------------------------------- Attachment: HBASE-17012_4.patch Updated patch - rebased against trunk. > Handle Offheap cells in CompressedKvEncoder > ------------------------------------------- > > Key: HBASE-17012 > URL: https://issues.apache.org/jira/browse/HBASE-17012 > Project: HBase > Issue Type: Sub-task > Components: regionserver > Affects Versions: 2.0.0 > Reporter: Anoop Sam John > Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: HBASE-17012_1.patch, HBASE-17012_2.patch, HBASE-17012_3.patch, HBASE-17012_4.patch > > > When we deal with off heap cells we will end up copying Cell components on heap > {code} > public void write(Cell cell) throws IOException { > ................. > write(cell.getRowArray(), cell.getRowOffset(), cell.getRowLength(), compression.rowDict); > write(cell.getFamilyArray(), cell.getFamilyOffset(), cell.getFamilyLength(), > compression.familyDict); > write(cell.getQualifierArray(), cell.getQualifierOffset(), cell.getQualifierLength(), > compression.qualifierDict); > ...... > out.write(cell.getValueArray(), cell.getValueOffset(), cell.getValueLength()); > ... > {code} > We need to avoid this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)