Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BE827200BB1 for ; Thu, 3 Nov 2016 15:20:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id BD479160AFE; Thu, 3 Nov 2016 14:20:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 248A3160B0B for ; Thu, 3 Nov 2016 15:19:59 +0100 (CET) Received: (qmail 69389 invoked by uid 500); 3 Nov 2016 14:19:59 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 69343 invoked by uid 99); 3 Nov 2016 14:19:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2016 14:19:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C2B022C2AB7 for ; Thu, 3 Nov 2016 14:19:58 +0000 (UTC) Date: Thu, 3 Nov 2016 14:19:58 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17012) Handle Offheap cells in CompressedKvEncoder MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 03 Nov 2016 14:20:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632843#comment-15632843 ] Anoop Sam John commented on HBASE-17012: ---------------------------------------- As part of this handle EncryptedKvEncoder#write(Cell) > Handle Offheap cells in CompressedKvEncoder > ------------------------------------------- > > Key: HBASE-17012 > URL: https://issues.apache.org/jira/browse/HBASE-17012 > Project: HBase > Issue Type: Sub-task > Components: regionserver > Affects Versions: 2.0.0 > Reporter: Anoop Sam John > Fix For: 2.0.0 > > > When we deal with off heap cells we will end up copying Cell components on heap > {code} > public void write(Cell cell) throws IOException { > ................. > write(cell.getRowArray(), cell.getRowOffset(), cell.getRowLength(), compression.rowDict); > write(cell.getFamilyArray(), cell.getFamilyOffset(), cell.getFamilyLength(), > compression.familyDict); > write(cell.getQualifierArray(), cell.getQualifierOffset(), cell.getQualifierLength(), > compression.qualifierDict); > ...... > out.write(cell.getValueArray(), cell.getValueOffset(), cell.getValueLength()); > ... > {code} > We need to avoid this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)