Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A632B200BDA for ; Tue, 29 Nov 2016 00:51:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A4EC4160B25; Mon, 28 Nov 2016 23:51:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EDA3F160B0D for ; Tue, 29 Nov 2016 00:51:00 +0100 (CET) Received: (qmail 94536 invoked by uid 500); 28 Nov 2016 23:51:00 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 94505 invoked by uid 99); 28 Nov 2016 23:50:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Nov 2016 23:50:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C40402C03DF for ; Mon, 28 Nov 2016 23:50:59 +0000 (UTC) Date: Mon, 28 Nov 2016 23:50:59 +0000 (UTC) From: "Appy (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16912) TEST: update HBaseTestingUtility to avoid direct use of filesystem / legacy implementation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 28 Nov 2016 23:51:01 -0000 [ https://issues.apache.org/jira/browse/HBASE-16912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703602#comment-15703602 ] Appy commented on HBASE-16912: ------------------------------ Re-formatted the commit message. {noformat} + @VisibleForTesting + public static HRegion createHRegion(final Configuration conf, + final HTableDescriptor hTableDescriptor, final HRegionInfo info, + final Path dir, final WAL wal, final boolean initialize) throws IOException { uagashe>>> can be changed to take regionStorage or masterStorage as an arg. Args conf, dir can be removed. {noformat} all other createHRegion follow same method signature, so we can leave it this way. {noformat} >> TestCoprocessorInterface.java HRegionInfo info = new HRegionInfo(tableName, null, null, false); - Path path = new Path(DIR + callingMethod); uagashe>>> should callingMethod still be used as a root directory to give separate area for each caller? {noformat} Tests are using separate table, so they are isolated. {noformat} >> TestRegionObserverStacking.java HRegionInfo info = new HRegionInfo(htd.getTableName(), null, null, false); - Path path = new Path(DIR + callingMethod); uagashe>>> same as before. {noformat} There's just one test, so doesn't really matter. {noformat} >> TestResettingCounters.java - } - Region region = HBaseTestingUtility.createRegionAndWAL(hri, path, conf, htd); uagashe>>> should we destroyRegion to clean up after previously aborted test, before we begin with new? {noformat} Only single test is there, so no cleanup needed. > TEST: update HBaseTestingUtility to avoid direct use of filesystem / legacy implementation > ------------------------------------------------------------------------------------------ > > Key: HBASE-16912 > URL: https://issues.apache.org/jira/browse/HBASE-16912 > Project: HBase > Issue Type: Sub-task > Components: Filesystem Integration > Affects Versions: hbase-14439 > Reporter: Sean Busbey > Assignee: Appy > Fix For: hbase-14439 > > Attachments: HBASE-16912.hbase-14439.001.patch, HBASE-16912.hbase-14439.002.patch, HBASE-16912.hbase-14439.002.review, fs-redo-HBTU.patch > > > Update the HBaseTestingUtility to ensure it relies on MasterStorage / RegionStorage APIs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)