Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F32BE200BB5 for ; Sun, 6 Nov 2016 09:35:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E6E38160AFC; Sun, 6 Nov 2016 08:35:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 37AD6160AD0 for ; Sun, 6 Nov 2016 09:35:00 +0100 (CET) Received: (qmail 58513 invoked by uid 500); 6 Nov 2016 08:34:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 58497 invoked by uid 99); 6 Nov 2016 08:34:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Nov 2016 08:34:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 755CF2C1F56 for ; Sun, 6 Nov 2016 08:34:58 +0000 (UTC) Date: Sun, 6 Nov 2016 08:34:58 +0000 (UTC) From: "Yu Li (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-16033) Add more details in logging of responseTooSlow/TooLarge MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 06 Nov 2016 08:35:01 -0000 [ https://issues.apache.org/jira/browse/HBASE-16033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-16033: -------------------------- Affects Version/s: (was: 1.2.1) 1.2.3 1.1.7 Fix Version/s: 1.1.8 1.2.4 Just picked this up in branch-1.1/1.2 > Add more details in logging of responseTooSlow/TooLarge > ------------------------------------------------------- > > Key: HBASE-16033 > URL: https://issues.apache.org/jira/browse/HBASE-16033 > Project: HBase > Issue Type: Improvement > Components: Operability > Affects Versions: 1.2.3, 1.1.7 > Reporter: Yu Li > Assignee: Yu Li > Fix For: 2.0.0, 1.3.0, 1.4.0, 0.98.21, 1.2.4, 1.1.8 > > Attachments: HBASE-16033.patch, HBASE-16033.patch, HBASE-16033.patch > > > Currently the log message when responseTooSlow/TooLarge is like: > {noformat} > 2016-06-08 12:18:04,363 WARN [B.defaultRpcServer.handler=127,queue=10,port=16020] > ipc.RpcServer: (responseTooSlow): {"processingtimems":13125,"call":"Multi(org.apache.hadoop.hbase.protobuf.generated.ClientProtos$MultiRequest)", > "client":"11.251.158.22:36331","starttimems":1465359471238,"queuetimems":1540116, > "class":"HRegionServer","responsesize":17,"method":"Multi"} > {noformat} > which is kind of helpless for debugging since we don't know on which table/region/row the request is against. > What's more, we could see some if-else check in the {{RpcServer#logResponse}} method which trying to do sth different when the {{param}} includes instance of {{Operation}}, but there's only one place invoking {{logResponse}} and the {{param}} is always an instance of {{Message}}. Checking the change history, I believe this is a left-over cleanup in work of HBASE-8214 > We will address the above issues, do some cleanup and improve the log just like {{RpcServer$Call#toString}} does to include table/region/row information of the request -- This message was sent by Atlassian JIRA (v6.3.4#6332)