Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5B2E4200BCB for ; Wed, 9 Nov 2016 09:23:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 59BAD160AEE; Wed, 9 Nov 2016 08:23:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9C083160AFD for ; Wed, 9 Nov 2016 09:22:59 +0100 (CET) Received: (qmail 92675 invoked by uid 500); 9 Nov 2016 08:22:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 92578 invoked by uid 99); 9 Nov 2016 08:22:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Nov 2016 08:22:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 843D32C0D55 for ; Wed, 9 Nov 2016 08:22:58 +0000 (UTC) Date: Wed, 9 Nov 2016 08:22:58 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15324) Jitter may cause desiredMaxFileSize overflow in ConstantSizeRegionSplitPolicy and trigger unexpected split MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 09 Nov 2016 08:23:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15650164#comment-15650164 ] Hudson commented on HBASE-15324: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-1.1-JDK7 #1815 (See [https://builds.apache.org/job/HBase-1.1-JDK7/1815/]) HBASE-15324 Jitter may cause desiredMaxFileSize overflow in (esteban: rev 9fb5a8608dff761160e217dc3dd5b2dfa9b4875d) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitPolicy.java > Jitter may cause desiredMaxFileSize overflow in ConstantSizeRegionSplitPolicy and trigger unexpected split > ---------------------------------------------------------------------------------------------------------- > > Key: HBASE-15324 > URL: https://issues.apache.org/jira/browse/HBASE-15324 > Project: HBase > Issue Type: Bug > Affects Versions: 2.0.0, 1.1.3 > Reporter: Yu Li > Assignee: Yu Li > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.5, 1.1.8 > > Attachments: HBASE-15324.patch, HBASE-15324_v2.patch, HBASE-15324_v3.patch, HBASE-15324_v3.patch > > > We introduce jitter for region split decision in HBASE-13412, but the following line in {{ConstantSizeRegionSplitPolicy}} may cause long value overflow if MAX_FILESIZE is specified to Long.MAX_VALUE: > {code} > this.desiredMaxFileSize += (long)(desiredMaxFileSize * (RANDOM.nextFloat() - 0.5D) * jitter); > {code} > In our case we specify MAX_FILESIZE to Long.MAX_VALUE to prevent target region to split. -- This message was sent by Atlassian JIRA (v6.3.4#6332)