Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 76189200BC9 for ; Sat, 12 Nov 2016 03:16:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 74B12160B14; Sat, 12 Nov 2016 02:16:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BF2C5160AF6 for ; Sat, 12 Nov 2016 03:15:59 +0100 (CET) Received: (qmail 93886 invoked by uid 500); 12 Nov 2016 02:15:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 93868 invoked by uid 99); 12 Nov 2016 02:15:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Nov 2016 02:15:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id AAC382C4C77 for ; Sat, 12 Nov 2016 02:15:58 +0000 (UTC) Date: Sat, 12 Nov 2016 02:15:58 +0000 (UTC) From: "Xiang Li (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14882) Provide a Put API that adds the provided family, qualifier, value without copying MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 12 Nov 2016 02:16:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658804#comment-15658804 ] Xiang Li commented on HBASE-14882: ---------------------------------- Hi Anoop, I see, got your idea. Thanks! I will update the patch to (1) Implement ExtendedCell (2) Add some comments to explain why IndividualBytesFieldCell at client end, has ExtendedCell implemented Please correct me if I did not get your idea. > Provide a Put API that adds the provided family, qualifier, value without copying > --------------------------------------------------------------------------------- > > Key: HBASE-14882 > URL: https://issues.apache.org/jira/browse/HBASE-14882 > Project: HBase > Issue Type: Improvement > Affects Versions: 1.2.0 > Reporter: Jerry He > Assignee: Xiang Li > Fix For: 2.0.0 > > Attachments: HBASE-14882.master.000.patch, HBASE-14882.master.001.patch, HBASE-14882.master.002.patch, HBASE-14882.master.003.patch > > > In the Put API, we have addImmutable() > {code} > /** > * See {@link #addColumn(byte[], byte[], byte[])}. This version expects > * that the underlying arrays won't change. It's intended > * for usage internal HBase to and for advanced client applications. > */ > public Put addImmutable(byte [] family, byte [] qualifier, byte [] value) > {code} > But in the implementation, the family, qualifier and value are still being copied locally to create kv. > Hopefully we should provide an API that truly uses immutable family, qualifier and value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)