hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17191) Make use of UnsafeByteOperations#unsafeWrap(ByteBuffer buffer) in PBUtil#toCell(Cell cell)
Date Wed, 30 Nov 2016 16:38:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709057#comment-15709057
] 

Anoop Sam John commented on HBASE-17191:
----------------------------------------

That is ok.  Better than the current way.  We will need duplicate and then proper positioning
and limit. slice might be not needed.

> Make use of UnsafeByteOperations#unsafeWrap(ByteBuffer buffer) in PBUtil#toCell(Cell
cell)
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17191
>                 URL: https://issues.apache.org/jira/browse/HBASE-17191
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>
> Since we now have support for BBs in UnsafeByteOperations#unsafeWrap(ByteBuffer) . So
for the non - java clients while creating the PB result we could avoid the copy to an temp
array. 
> Since we have a support to write to BB in ByteOutput having a result backed by Bytebuffer
should be fine. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message