hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl
Date Thu, 24 Nov 2016 18:16:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693948#comment-15693948
] 

Anoop Sam John edited comment on HBASE-17174 at 11/24/16 6:16 PM:
------------------------------------------------------------------

That is a wrong expectation itself IMO. :-)  The pool is created by some other code and been
passed.. So the other part of code should be doing the pool close after the BufferedMutator
close.
See how we handle similar scenario in HTable
{code}
this.pool = pool;
    if (pool == null) {
      this.pool = getDefaultExecutor(this.configuration);
      this.cleanupPoolOnClose = true;
    } else {
      this.cleanupPoolOnClose = false;
    }
{code}
When user passed a pool, we will never close it as part of HTable#close.


was (Author: anoop.hbase):
That is a wrong expectation itself IMO. :-)  The pool is created by some other code and been
passed.. So the other part of code should be doing the pool close after the BufferedMutator
close.

> Use shared threadpool in BufferedMutatorImpl
> --------------------------------------------
>
>                 Key: HBASE-17174
>                 URL: https://issues.apache.org/jira/browse/HBASE-17174
>             Project: HBase
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17174.v0.patch, HBASE-17174.v1.patch
>
>
> A update-heavy application, for example, loader, creates many BufferedMutator for batch
updates. But these BufferedMutators can’t share a large threadpool because the shutdown()
method will be called when closing any BufferedMutator. This patch adds a flag into BufferedMutatorParams
for preventing calling the shutdown() method in BufferedMutatorImpl#close



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message