hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17123) Add postBulkLoadHFile variant that notifies the final paths for the hfiles
Date Mon, 21 Nov 2016 07:18:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15682757#comment-15682757
] 

Anoop Sam John commented on HBASE-17123:
----------------------------------------

This is committed I think.
There is one issue with the patch.  RegionObserver added with new hook and added the def impl
for it, calling the old hook. But BaseRegionObserver is having impl for both methods returning
passed boolean. Normally users extend BaseRegionObserver and then we wont get the BC fix.
So in BaseRegionObserver we have to make the new hook to call the old method.

> Add postBulkLoadHFile variant that notifies the final paths for the hfiles
> --------------------------------------------------------------------------
>
>                 Key: HBASE-17123
>                 URL: https://issues.apache.org/jira/browse/HBASE-17123
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 2.0.0
>
>         Attachments: 17123.v1.txt, 17123.v3.txt, 17123.v4.txt, 17123.v5.txt
>
>
> Currently the postBulkLoadHFile() hook passes the same familyPaths parameter which it
receives as method parameter.
> See code in SecureBulkLoadManager :
> {code}
>        loaded = region.getCoprocessorHost().postBulkLoadHFile(familyPaths, loaded);
> {code}
> Meaning, the paths are not final, moved paths of the loaded hfiles.
> This issue is to add a variant which notifies the final paths of the loaded hfiles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message