hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17088) Refactor RWQueueRpcExecutor/BalancedQueueRpcExecutor/RpcExecutor
Date Fri, 18 Nov 2016 07:33:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15676046#comment-15676046

Duo Zhang commented on HBASE-17088:

[~zghaobac] Could you please prepare a patch for branch-1? Be careful that the {{BalancedQueueRpcExecutor}}
and {{RWQueueRpcExecutor}} and marked as LimitedPrivate to coprocessor and phoenix, so you'd
better keep the constructors which is removed in the patch for master in the patch for branch-1
and mark them as deprecated.


> Refactor RWQueueRpcExecutor/BalancedQueueRpcExecutor/RpcExecutor
> ----------------------------------------------------------------
>                 Key: HBASE-17088
>                 URL: https://issues.apache.org/jira/browse/HBASE-17088
>             Project: HBase
>          Issue Type: Improvement
>          Components: rpc
>    Affects Versions: 2.0.0
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>         Attachments: HBASE-17088-v1.patch, HBASE-17088-v2.patch, HBASE-17088-v3.patch,
HBASE-17088-v3.patch, HBASE-17088-v4.patch, HBASE-17088-v4.patch
> 1. The RWQueueRpcExecutor has eight constructor method and the longest one has ten parameters.
But It is only used in SimpleRpcScheduler and easy to confused when read the code.
> 2. There are duplicate method implement in RWQueueRpcExecutor and BalancedQueueRpcExecutor.
They can be implemented in their parent class RpcExecutor.
> 3. SimpleRpcScheduler read many configs to new RpcExecutor. But the CALL_QUEUE_SCAN_SHARE_CONF_KEY
and CALL_QUEUE_CODEL_LIFO_THRESHOLD are only needed by AdaptiveLifoCoDelCallQueue.
> So I thought we can refactor it. Suggestions are welcome.
> Review board: https://reviews.apache.org/r/53726/

This message was sent by Atlassian JIRA

View raw message