hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guanghao Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17088) Refactor RWQueueRpcExecutor/BalancedQueueRpcExecutor/RpcExecutor
Date Tue, 15 Nov 2016 11:37:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15666916#comment-15666916

Guanghao Zhang commented on HBASE-17088:

The timeout ut passed locally. The test timeout because the precommit job oom. And these tests
run for a long time. After HBASE-13197, HConnectionManager has been removed and ConnectionImplemention
has been a top-level class. I thought we can split TestHCM to some small tests. Now it run
almost ten minutes. If the precommit job oom because other ut and TestHCM will be timeout

> Refactor RWQueueRpcExecutor/BalancedQueueRpcExecutor/RpcExecutor
> ----------------------------------------------------------------
>                 Key: HBASE-17088
>                 URL: https://issues.apache.org/jira/browse/HBASE-17088
>             Project: HBase
>          Issue Type: Improvement
>          Components: rpc
>    Affects Versions: 2.0.0
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>         Attachments: HBASE-17088-v1.patch, HBASE-17088-v2.patch, HBASE-17088-v3.patch
> 1. The RWQueueRpcExecutor has eight constructor method and the longest one has ten parameters.
But It is only used in SimpleRpcScheduler and easy to confused when read the code.
> 2. There are duplicate method implement in RWQueueRpcExecutor and BalancedQueueRpcExecutor.
They can be implemented in their parent class RpcExecutor.
> 3. SimpleRpcScheduler read many configs to new RpcExecutor. But the CALL_QUEUE_SCAN_SHARE_CONF_KEY
and CALL_QUEUE_CODEL_LIFO_THRESHOLD are only needed by AdaptiveLifoCoDelCallQueue.
> So I thought we can refactor it. Suggestions are welcome.
> Review board: https://reviews.apache.org/r/53726/

This message was sent by Atlassian JIRA

View raw message