hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17087) Enable Aliasing for CodedInputStream created by ByteInputByteString#newCodedInput
Date Mon, 14 Nov 2016 21:01:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665002#comment-15665002
] 

stack commented on HBASE-17087:
-------------------------------

Patch LGTM.

This is not enough I think.

>From the end of the README.txt in this module:

"If you have patches for the protobuf, add them to
src/main/patches directory. They will be applied after
protobuf is shaded and unbundled into src/main/java."

So, here we are applying a patch on top of a file what was itself added by a patch (see the
src/main/patches/HBASE-15789_V2.patch file).

Your change here could be lost.

What I think you need to do is to also add this patch to the src/main/patches dir. Patches
will be applied in order (this pach is after 15789).

This way when the proto gen stuff runs, we'll generate protos, pull down protobuf, and apply
all patches, so when result is checked in... all patches will be in place.

> Enable Aliasing for CodedInputStream created by ByteInputByteString#newCodedInput
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-17087
>                 URL: https://issues.apache.org/jira/browse/HBASE-17087
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17087.patch, HBASE-17087.patch
>
>
> Missed setting this while doing HBASE-15789.  We make CIS with 'bufferIsImmutable' as
true but we should do enableAliasing also to avoid copy while building PB objects from this
new CIS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message