hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17085) AsyncFSWAL may issue unnecessary AsyncDFSOutput.sync
Date Wed, 16 Nov 2016 05:16:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669456#comment-15669456
] 

Duo Zhang commented on HBASE-17085:
-----------------------------------

Yeah I mean the sync method without txid. It is also called at many places so we need to consider
it. Your patch may cause infinite wait when sync() is called.

> AsyncFSWAL may issue unnecessary AsyncDFSOutput.sync
> ----------------------------------------------------
>
>                 Key: HBASE-17085
>                 URL: https://issues.apache.org/jira/browse/HBASE-17085
>             Project: HBase
>          Issue Type: Sub-task
>          Components: wal
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17085-v1.patch, HBASE-17085-v2.patch, HBASE-17085-v2.patch,
HBASE-17085.patch
>
>
> The problem is in appendAndSync method, we will issue an  AsyncDFSOutput.sync if syncFutures
is not empty. The SyncFutures in syncFutures can only be removed after an AsyncDFSOutput.sync
comes back, so before the AsyncDFSOutput.sync actually returns, we will always issue an  AsyncDFSOutput.sync
after an append even if there is no new sync request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message