hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17082) ForeignExceptionUtil isn’t packaged when building shaded protocol with -Pcompile-protobuf
Date Wed, 16 Nov 2016 07:04:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669665#comment-15669665
] 

stack commented on HBASE-17082:
-------------------------------

(I forgot to push this comment. This is my first attempt at a fix. It got reverted subsequently
replaced by a second attempt that ending up working).

I pushed this attempt at a fix (It is hard to do the yetus env. locally -- it takes a long
time). Trying the yetus env locally, I get a different compile error out of hbase-client.
Hopefully that is a good sign. Committed so could try your test patch [~chia7712].  Another
issue we have to deal w/ is the protoc check being run in modules that don't have protoc.
Will need to mess in the hbase-personality...

{code}
commit 8847a7090260038afd538de274378a691ca96c4f
Author: Michael Stack <stack@apache.org>
Date:   Tue Nov 15 12:22:51 2016 -0800

    HBASE-17082 ForeignExceptionUtil isnt packaged when building shaded protocol with -Pcompile-protobuf;
Attempted Fix

diff --git a/hbase-protocol-shaded/pom.xml b/hbase-protocol-shaded/pom.xml
index 2b221d5..aebef81 100644
--- a/hbase-protocol-shaded/pom.xml
+++ b/hbase-protocol-shaded/pom.xml
@@ -181,7 +181,8 @@
       </activation>
       <properties>
         <profile.id>compile-protobuf</profile.id>
-        <sources.dir>${project.build.directory}/protoc-generated-sources</sources.dir>
+        <!--Include original and the generated protos dir when talking of sources-->
+        <sources.dir>${basedir}/src/main/java ${project.build.directory}/protoc-generated-sources</sources.dir>
         <classes.dir>${project.build.directory}/protoc-generated-classes</classes.dir>
         <!--When the compile for this profile runs, make sure it makes jars that
              can be related back to this shading profile. Give them a shading prefix.
{code}

> ForeignExceptionUtil isn’t packaged when building shaded protocol with -Pcompile-protobuf
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-17082
>                 URL: https://issues.apache.org/jira/browse/HBASE-17082
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>             Fix For: 2.0.0
>
>         Attachments: 17082_attempted_fix.txt, 17082_attempted_fix2.txt, HBASE-17082.nothing.patch,
HBASE-17082.nothing.patch, HBASE-17082.nothing.patch, HBASE-17082.v0.patch, HBASE-17082.v1.patch,
patch-unit-hbase-client (after v1.patch).txt, patch-unit-hbase-server (after v1.patch).txt
>
>
> The source folder will be replaced from src/main/java to project.build.directory/protoc-generated-sources
when building shaded protocol with -Pcompile-protobuf, but we do not copy the ForeignExceptionUtil.
So the final jar lacks the ForeignExceptionUtil and it causes the test error for hbase-client
and hbase-server.
> {noformat}
> [ERROR] /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:[169,36]
cannot find symbol
>   symbol:   class ForeignExceptionUtil
>   location: package org.apache.hadoop.hbase.util
> [ERROR] /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:[100,36]
cannot find symbol
>   symbol:   class ForeignExceptionUtil
>   location: package org.apache.hadoop.hbase.util
> [ERROR] /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:[2144,17]
cannot find symbol
>   symbol:   variable ForeignExceptionUtil
>   location: class org.apache.hadoop.hbase.regionserver.HRegionServer
> [ERROR] /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:[938,32]
cannot find symbol
>   symbol:   variable ForeignExceptionUtil
>   location: class org.apache.hadoop.hbase.master.MasterRpcServices
> {noformat}
> This bug blocks the patches which are against the hbase-protocol-shaded module. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message