hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-17082) ForeignExceptionUtil isn’t packaged when building shaded protocol with -Pcompile-protobuf
Date Wed, 16 Nov 2016 04:08:00 GMT

     [ https://issues.apache.org/jira/browse/HBASE-17082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-17082:
--------------------------
    Attachment: 17082_attempted_fix2.txt

Here is attempt #2. I reverted #1. It did not fix the problem.

The problem turns out to be mvns dodged install of a jar at end of install step. It goes so
far as to take a renamed jar and install it as the modules product. 

The trick in hbase-protocol-shaded is to build protos into a scratch jar that then gets shaded,
undone over src, patched and then committed. Our scratch jar -- missing some classes -- was
getting installed into the repo. Usually not an issue but it became an issue during the run
that this 'nothing' patch provokes where client and server modules are having their protos
generated (they have none but yetus thinks it needs to run).  cilent and server need the repo
to successfully build but just before their proto check, the hbase-protocol-shaded ran polluting
the repo with the scratch jar as though it were the legit output of the hbase-protocol-shaded
build.

Let me try the nothing patch against this commit.


> ForeignExceptionUtil isn’t packaged when building shaded protocol with -Pcompile-protobuf
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-17082
>                 URL: https://issues.apache.org/jira/browse/HBASE-17082
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: ChiaPing Tsai
>            Assignee: stack
>             Fix For: 2.0.0
>
>         Attachments: 17082_attempted_fix.txt, 17082_attempted_fix2.txt, HBASE-17082.nothing.patch,
HBASE-17082.nothing.patch, HBASE-17082.nothing.patch, HBASE-17082.v0.patch, HBASE-17082.v1.patch,
patch-unit-hbase-client (after v1.patch).txt, patch-unit-hbase-server (after v1.patch).txt
>
>
> The source folder will be replaced from src/main/java to project.build.directory/protoc-generated-sources
when building shaded protocol with -Pcompile-protobuf, but we do not copy the ForeignExceptionUtil.
So the final jar lacks the ForeignExceptionUtil and it causes the test error for hbase-client
and hbase-server.
> {noformat}
> [ERROR] /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:[169,36]
cannot find symbol
>   symbol:   class ForeignExceptionUtil
>   location: package org.apache.hadoop.hbase.util
> [ERROR] /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:[100,36]
cannot find symbol
>   symbol:   class ForeignExceptionUtil
>   location: package org.apache.hadoop.hbase.util
> [ERROR] /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:[2144,17]
cannot find symbol
>   symbol:   variable ForeignExceptionUtil
>   location: class org.apache.hadoop.hbase.regionserver.HRegionServer
> [ERROR] /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:[938,32]
cannot find symbol
>   symbol:   variable ForeignExceptionUtil
>   location: class org.apache.hadoop.hbase.master.MasterRpcServices
> {noformat}
> This bug blocks the patches which are against the hbase-protocol-shaded module. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message