hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17076) implement getAndPut() and getAndDelete()
Date Fri, 11 Nov 2016 22:49:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658411#comment-15658411
] 

Hadoop QA commented on HBASE-17076:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s {color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} |
{color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color}
| {color:green} The patch appears to include 2 new or modified test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s {color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 3s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 4s {color} | {color:green}
master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 10m 13s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 3s {color}
| {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 2s {color} | {color:red}
hbase-protocol-shaded in master has 24 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 41s {color} |
{color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s {color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 48s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 15s {color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m 15s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 15s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 10m 37s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 3s {color}
| {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red}
The patch has 21 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 27m 43s {color}
| {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5
2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 25s {color} | {color:red}
Patch generated 1 new protoc errors in hbase-server. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 56s {color} | {color:red}
hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 51s {color} | {color:red}
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 15s {color} | {color:red}
hbase-client generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 25s {color} | {color:red}
hbase-server generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 16s {color} | {color:green}
hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 27s {color} | {color:green}
hbase-protocol-shaded in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 12s {color} | {color:red}
hbase-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 15s {color} | {color:green}
hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 18s {color} | {color:green}
hbase-hadoop2-compat in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 22s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 1s {color} | {color:red}
hbase-rest in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 42s {color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 100m 47s {color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-client |
|  |  Null passed for non-null parameter of new org.apache.hadoop.hbase.client.Update(byte[],
RowUpdater) in org.apache.hadoop.hbase.protobuf.ProtobufUtil.toUpdate(ClientProtos$MutationProto,
CellScanner)  Method invoked at ProtobufUtil.java:of new org.apache.hadoop.hbase.client.Update(byte[],
RowUpdater) in org.apache.hadoop.hbase.protobuf.ProtobufUtil.toUpdate(ClientProtos$MutationProto,
CellScanner)  Method invoked at ProtobufUtil.java:[line 658] |
| FindBugs | module:hbase-server |
|  |  Switch statement found in org.apache.hadoop.hbase.regionserver.HRegion.doDelta(Region$Operation,
Mutation, long, long, boolean) where default case is missing  At HRegion.java:Mutation, long,
long, boolean) where default case is missing  At HRegion.java:[lines 7331-7339] |
| Failed junit tests | hadoop.hbase.rest.TestTableResource |
| Timed out junit tests | org.apache.hadoop.hbase.rest.TestNamespacesInstanceResource |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:7bda515 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12838611/HBASE-17076-v0.patch
|
| JIRA Issue | HBASE-17076 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle
 compile  cc  hbaseprotoc  |
| uname | Linux 610baa56b84e 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 5e91b45 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/4438/artifact/patchprocess/branch-findbugs-hbase-protocol-shaded-warnings.html
|
| whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/4438/artifact/patchprocess/whitespace-eol.txt
|
| hbaseprotoc | https://builds.apache.org/job/PreCommit-HBASE-Build/4438/artifact/patchprocess/patch-hbaseprotoc-hbase-server.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/4438/artifact/patchprocess/new-findbugs-hbase-client.html
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/4438/artifact/patchprocess/new-findbugs-hbase-server.html
|
| javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/4438/artifact/patchprocess/diff-javadoc-javadoc-hbase-client.txt
|
| javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/4438/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/4438/artifact/patchprocess/patch-unit-hbase-client.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/4438/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/4438/artifact/patchprocess/patch-unit-hbase-rest.txt
|
| unit test logs |  https://builds.apache.org/job/PreCommit-HBASE-Build/4438/artifact/patchprocess/patch-unit-hbase-rest.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/4438/testReport/ |
| modules | C: hbase-protocol hbase-protocol-shaded hbase-client hbase-hadoop-compat hbase-hadoop2-compat
hbase-server hbase-rest U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/4438/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> implement getAndPut() and getAndDelete()
> ----------------------------------------
>
>                 Key: HBASE-17076
>                 URL: https://issues.apache.org/jira/browse/HBASE-17076
>             Project: HBase
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: ChiaPing Tsai
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17076-v0.patch
>
>
> We implement the getAndPut() and getAndDelete() by coprocessor, but there are a lot of
duplicate effort (e.g., data checks, row lock, returned value, and wal). It is cool if we
provide the compare-and-swap primitive.
> The draft patch is attached. Any advice and suggestions will be greatly appreciated.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message